Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/dev/feed-cvo-custom-graphs.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Example:
}
```

More examples can be found at [fauxinnati](https://fauxinnati-fauxinnati.apps.ota-stage.q2z4.p1.openshiftapps.com/). See [a demo](https://asciinema.org/a/hUwpV4pyhGK0k0nI68KzAO3pv) to use it as `cv.spec.upstream`. It currently does not inject real payload URLs, and thus we cannot do a cluster upgrade with it. We may modify the returned graph and host it somewhere (see the example in this page) to achieve it.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix the field reference in the example.

cv.spec.upstream looks like a typo; readers are likely to look for spec.upstream (or clusterversion.spec.upstream).

✏️ Proposed text fix
-More examples can be found at [fauxinnati](https://fauxinnati-fauxinnati.apps.ota-stage.q2z4.p1.openshiftapps.com/). See [a demo](https://asciinema.org/a/hUwpV4pyhGK0k0nI68KzAO3pv) to use it as `cv.spec.upstream`. It currently does not inject real payload URLs, and thus we cannot do a cluster upgrade with it. We may modify the returned graph and host it somewhere (see the example in this page) to achieve it.
+More examples can be found at [fauxinnati](https://fauxinnati-fauxinnati.apps.ota-stage.q2z4.p1.openshiftapps.com/). See [a demo](https://asciinema.org/a/hUwpV4pyhGK0k0nI68KzAO3pv) to use it as `spec.upstream`. It currently does not inject real payload URLs, and thus we cannot do a cluster upgrade with it. We may modify the returned graph and host it somewhere (see the example in this page) to achieve it.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
More examples can be found at [fauxinnati](https://fauxinnati-fauxinnati.apps.ota-stage.q2z4.p1.openshiftapps.com/). See [a demo](https://asciinema.org/a/hUwpV4pyhGK0k0nI68KzAO3pv) to use it as `cv.spec.upstream`. It currently does not inject real payload URLs, and thus we cannot do a cluster upgrade with it. We may modify the returned graph and host it somewhere (see the example in this page) to achieve it.
More examples can be found at [fauxinnati](https://fauxinnati-fauxinnati.apps.ota-stage.q2z4.p1.openshiftapps.com/). See [a demo](https://asciinema.org/a/hUwpV4pyhGK0k0nI68KzAO3pv) to use it as `spec.upstream`. It currently does not inject real payload URLs, and thus we cannot do a cluster upgrade with it. We may modify the returned graph and host it somewhere (see the example in this page) to achieve it.
🤖 Prompt for AI Agents
In `@docs/dev/feed-cvo-custom-graphs.md` at line 31, The documentation uses an
inconsistent field reference `cv.spec.upstream`; update the example text to
reference the correct Kubernetes resource field name (use `spec.upstream` or the
fully-qualified `clusterversion.spec.upstream`) so readers can find the right
field; replace `cv.spec.upstream` with `spec.upstream` (or
`clusterversion.spec.upstream`) in the sentence and ensure any surrounding
examples/comments use the same corrected symbol.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
More examples can be found at [fauxinnati](https://fauxinnati-fauxinnati.apps.ota-stage.q2z4.p1.openshiftapps.com/). See [a demo](https://asciinema.org/a/hUwpV4pyhGK0k0nI68KzAO3pv) to use it as `cv.spec.upstream`. It currently does not inject real payload URLs, and thus we cannot do a cluster upgrade with it. We may modify the returned graph and host it somewhere (see the example in this page) to achieve it.
More examples can be found at [fauxinnati](https://fauxinnati-fauxinnati.apps.ota-stage.q2z4.p1.openshiftapps.com/). See [a demo](https://asciinema.org/a/hUwpV4pyhGK0k0nI68KzAO3pv) to use it as `cv.spec.upstream`. It currently does not inject real payload URLs, and thus, we cannot do a cluster upgrade with it. We may modify the returned graph and host it somewhere (see the example on this page) to achieve it.


### Step-2

Host the file in any location where the cluster version operator can access it.
Expand Down