Skip to content

Conversation

@danehans
Copy link
Contributor

Adds GCP metadata hostnames to default noProxy based on GCP doc recommendations.

@openshift-ci-robot
Copy link
Contributor

@danehans: This pull request references Bugzilla bug 1753930, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes Bug 1753930: Adds GCP metadata hostnames to default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2019
@danehans danehans changed the title Fixes Bug 1753930: Adds GCP metadata hostnames to default noProxy Fixes Bug 1754049: Adds GCP metadata hostnames to default noProxy Sep 25, 2019
@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 25, 2019
@openshift-ci-robot
Copy link
Contributor

@danehans: This pull request references Bugzilla bug 1754049, which is invalid:

  • expected dependent Bugzilla bug 1753930 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Fixes Bug 1754049: Adds GCP metadata hostnames to default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 25, 2019
@danehans
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@danehans: This pull request references Bugzilla bug 1754049, which is invalid:

  • expected dependent Bugzilla bug 1753930 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Previously, only the metadata IP was being added to the default
noProxy list. This causes calls to GCP metadata that use hostname
instead of IP to be proxied.
@squeed
Copy link
Contributor

squeed commented Sep 26, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@danehans
Copy link
Contributor Author

fail [github.com/openshift/origin/test/extended/builds/valuefrom.go:42]: Unexpected error:
    <*errors.errorString | 0xc003506f90>: {
        s: "Failed to import expected imagestreams",
    }
    Failed to import expected imagestreams
occurred

/test e2e-aws

@wking
Copy link
Member

wking commented Sep 27, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1754049, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Sep 27, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 27, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1754049, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4175354 into openshift:master Sep 27, 2019
@openshift-ci-robot
Copy link
Contributor

@danehans: All pull requests linked via external trackers have merged. Bugzilla bug 1754049 has been moved to the MODIFIED state.

Details

In response to this:

Fixes Bug 1754049: Adds GCP metadata hostnames to default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link
Contributor Author

danehans commented Oct 7, 2019

/cherry-pick release-4.2

@openshift-cherrypick-robot

@danehans: new pull request created: #338

Details

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants