Skip to content

Conversation

@damdo
Copy link
Member

@damdo damdo commented Oct 31, 2023

Temporarily carrying upstream fix (kubernetes-sigs/cluster-api-provider-gcp#1056) to metadata file until next patch release.

@damdo damdo changed the title UPSTREAM: 1056: fix: update metadata file to add the 1.5 releases OCPCLOUD-2218: UPSTREAM: 1056: fix: update metadata file to add the 1.5 releases Oct 31, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 31, 2023

@damdo: This pull request references OCPCLOUD-2218 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Temporarily carrying upstream fix (kubernetes-sigs/cluster-api-provider-gcp#1056) to metadata file until next patch release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2023
@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 77d470b and 2 for PR HEAD 68fad10 in total

@damdo
Copy link
Member Author

damdo commented Nov 1, 2023

Ref: #207 (comment)

Still seeing alerting failures of e2e-gcp-serial. These are unrelated to this change as it was discussed #202 (comment).
Hence overriding this
/override ci/prow/e2e-gcp-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-gcp-serial

In response to this:

Ref: #207 (comment)

Still seeing alerting failures of e2e-gcp-serial. These are unrelated to this change as it was discussed #202 (comment).
Hence overriding this
/override ci/prow/e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 4adfdf1 into openshift:master Nov 1, 2023
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-gcp-cluster-api-controllers-container-v4.15.0-202311202349.p0.g4adfdf1.assembly.stream for distgit ose-gcp-cluster-api-controllers.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants