Skip to content

Conversation

@stephenfin
Copy link

This reverts commit a7cb24b. openshift/release still uses master as the branch name. Absence of this logic prevent rehearsals.

This reverts commit a7cb24b.
openshift/release still uses "master" as the branch name. Absence of
this logic prevent rehearsals.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2025
@openshift-ci-robot
Copy link

@stephenfin: This pull request explicitly references no jira issue.

In response to this:

This reverts commit a7cb24b. openshift/release still uses master as the branch name. Absence of this logic prevent rehearsals.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from RadekManak and nrb December 5, 2025 15:05
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign racheljpg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025

Walkthrough

The pull request modifies openshift/e2e-tests.sh to conditionally assign CCAPIO_BASE_REF based on PULL_BASE_REF. When PULL_BASE_REF is "master", it sets CCAPIO_BASE_REF to "main"; otherwise, it propagates the value directly. This aligns the master branch reference to main for the upstream cluster-capi-operator dependency.

Changes

Cohort / File(s) Summary
Conditional branch reference mapping
openshift/e2e-tests.sh
Added if-fi conditional block to map PULL_BASE_REF to CCAPIO_BASE_REF: sets to "main" when PULL_BASE_REF is "master", otherwise propagates the value unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the conditional logic correctly maps "master" to "main" and other branches pass through unchanged
  • Confirm the shell syntax (if-fi block) is properly formatted
  • Ensure the change aligns with the intended upstream dependency versioning strategy
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 47bf1f7 and 5ef6e2e.

📒 Files selected for processing (1)
  • openshift/e2e-tests.sh (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • openshift/e2e-tests.sh
🔇 Additional comments (1)
openshift/e2e-tests.sh (1)

10-15: LGTM!

The conditional mapping correctly addresses the revert requirement: when PULL_BASE_REF is "master", it maps to "main" (cluster-capi-operator's default branch), and otherwise propagates the base ref unchanged. This restores compatibility with openshift/release's use of "master" and fixes the rehearsal regression described in the PR.


Comment @coderabbitai help to get the list of available commands and usage tips.

@stephenfin
Copy link
Author

/assign @nrb

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

@stephenfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 5ef6e2e link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


# Default branch for both CCAPIO and this repo should be `main`.
CCAPIO_BASE_REF=$PULL_BASE_REF
if [ "${PULL_BASE_REF}" == "master" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stephen could we add an or and also add main to this here now. The default branch for this one has changed it seems. TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants