Switch to Continuous Usage Stats for vLLM > 0.6.4.post1 #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tested with vLLM 0.6.3.post1, 0.6.4.post1, and 0.6.6.post1. |
Member
|
I was thinking that we were previously receiving token counts between
responses considering this vllm PR explicitly makes it cumulative. You can
ignore the comment if everything is working as expected.
…On Fri, Jan 17, 2025, 4:27 PM Samuel Monson ***@***.***> wrote:
@sjmonson <https://github.com/sjmonson> requested your review on: #81
<#81> WIP: Switch to
Continuous Usage Stats for vLLM > 0.6.4.post1.
—
Reply to this email directly, view it on GitHub
<#81 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKIOQKBCGORB6LUKMJTAPI32LFYTFAVCNFSM6AAAAABVMSPTRSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHE4DENJVGU3TKNI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
sjmonson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80