Skip to content

Remove ingress controller manifest. #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
russellb merged 1 commit into from
Aug 20, 2019
Merged

Remove ingress controller manifest. #715

russellb merged 1 commit into from
Aug 20, 2019

Conversation

@russellb
Copy link
Member

@russellb russellb commented Jul 31, 2019 •
edited
Loading

This is no longer required, as we install a 3 node cluster by default.
The installer will automatically adjust the scheduler configuration to
make master nodes schedulable. For more details on that change, see:
openshift/installer#2004

Closes issue #705

@russellb russellb added the CI check this PR with CI label Jul 31, 2019
stbenjam
stbenjam approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@stbenjam stbenjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@russellb
Copy link
Member Author

russellb commented Jul 31, 2019

This isn't working consistently for me locally. It seems the machine-config-operator is not reliably acting on this value at startup. I just had to edit the mastersSchedulable: true setting to false and back to true to trigger reconciliation

@russellb
Copy link
Member Author

russellb commented Jul 31, 2019

bug filed: openshift/machine-config-operator#1024

@metal3ci
Copy link

metal3ci commented Aug 1, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/980/

@hardys hardys mentioned this pull request Aug 13, 2019
Merged
@metal3ci
Copy link

metal3ci commented Aug 13, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1032/

@metal3ci
Copy link

metal3ci commented Aug 19, 2019

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1063/

@hardys
Copy link

hardys commented Aug 19, 2019

Ok this looks good now since the latest rebase, @russellb if you're happy we can go ahead and land this?

@russellb
Remove ingress controller manifest.
93fc294 
This is no longer required, as we install a 3 node cluster by default.
The installer will automatically adjust the scheduler configuration to
make master nodes schedulable. For more details on that change, see:
openshift/installer#2004

Closes issue openshift-metal3#705
@russellb russellb changed the title Explicitly install a 3 node cluster. Remove ingress controller manifest. Aug 19, 2019
@russellb
Copy link
Member Author

russellb commented Aug 19, 2019

I've rebased this and updated the commit message to reflect what was remaining. Let's let CI run once more ...

@metal3ci
Copy link

metal3ci commented Aug 19, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1064/

@metal3ci
Copy link

metal3ci commented Aug 20, 2019

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1070/

@russellb russellb merged commit 1f80145 into openshift-metal3:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stbenjam stbenjam stbenjam approved these changes

Assignees

No one assigned

Labels

CI check this PR with CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@russellb @metal3ci @hardys @stbenjam