-
Notifications
You must be signed in to change notification settings - Fork 343
Refactor JWT Vendor to take a claims builder and rename oboEnabled to enabled #5436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5436 +/- ##
==========================================
- Coverage 72.40% 72.36% -0.05%
==========================================
Files 393 395 +2
Lines 24299 24317 +18
Branches 3714 3713 -1
==========================================
+ Hits 17593 17596 +3
- Misses 4877 4892 +15
Partials 1829 1829
🚀 New features to boost your workflow:
|
RyanL1997
previously approved these changes
Jun 24, 2025
Collaborator
RyanL1997
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/main/java/org/opensearch/security/authtoken/jwt/claims/OBOJwtClaimsBuilder.java
Show resolved
Hide resolved
Signed-off-by: Darshit Chanpura <[email protected]>
src/main/java/org/opensearch/security/authtoken/jwt/claims/JwtClaimsBuilder.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/identity/SecurityTokenManager.java
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
RyanL1997
approved these changes
Jun 24, 2025
shikharj05
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small refactor ahead of cwperks#56 to make the JWTVendor more flexible. Currently the JWTVendor is tailor made for On-Behalf-Of tokens, but will be re-used for API Tokens and needs more flexibility. This PR adds a notion of a JWTClaimsBuilder to build the claims set for different types of tokens issued by the security plugin. This PR adds an OBOJwtClaimsSetBuilder for building the claims set of an OBO token.
It also has a small refactor of
onoEnabled->enabledsince its clear in context what the variable is enabling.Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.