[Breaking] Rename OpensearchContainer to OpenSearchContainer #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
andrross
commented
Mar 12, 2025
reta
reviewed
Mar 12, 2025
src/test/java/org/opensearch/testcontainers/OpenSearchContainerTest.java
Outdated
Show resolved
Hide resolved
dblock
previously approved these changes
Mar 12, 2025
Member
I love me a good rename. |
There are no logical changes here only a rename of the existing class. Signed-off-by: Andrew Ross <[email protected]>
reta
previously approved these changes
Mar 13, 2025
Collaborator
|
Thanks @andrross ! I will create a branch for 2.1.x and merge this one shortly |
Signed-off-by: Andriy Redko <[email protected]>
reta
changed the title
reta
previously approved these changes
Mar 14, 2025
Signed-off-by: Andriy Redko <[email protected]>
reta
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no logical changes here only a rename of the existing class.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.