Bump up cmake version to 3.26.4#4822
Conversation
Signed-off-by: Naveen Tatikonda <[email protected]>
Signed-off-by: Naveen Tatikonda <[email protected]>
1d511c8 to
ddf9818
Compare
There was a problem hiding this comment.
Have an offline talk with @naveentatikonda and he will double check if there is a higher version of cmake we can move to to avoid constant update of images.
As of now faiss label to be at least 3.24.0
for
Let's see if we can bump to 3.24.3 as least as that is the last version available on scoop for windows.
Thanks.
b771ff7 to
94fafc0
Compare
|
Tested with CMake version 3.26.4 on Linux machine and able to build k-NN libraries, so bumping cmake version to 3.26.4 |
94fafc0 to
14881e5
Compare
peterzhuamazon
left a comment
There was a problem hiding this comment.
Hi @naveentatikonda can you remove all the changes for items within legacy folder as they should remain the same as old templates.
Thanks.
14881e5 to
cccfd09
Compare
Signed-off-by: Naveen Tatikonda <[email protected]>
cccfd09 to
805edc5
Compare
@peterzhuamazon reverted those changes in legacy folder. Pls take a look |
Thanks @naveentatikonda , I will trigger the image building now. |
|
Using |
Please ignore the latest sha of |
Description
Bump up cmake version to 3.26.4 to fix the failing CI in k-NN plugin
https://github.com/opensearch-project/k-NN/actions/runs/9822873197/job/27120072059?pr=1796
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.