[BugFix] Fixing KNNMethodContext resolution when documents are ingested and a flaky test#2072
Conversation
…ed and a flaky test Signed-off-by: Navneet Verma <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2072-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f6b177986ab89676fcca2b1fdedad580896b8c3
# Push it to GitHub
git push --set-upstream origin backport/backport-2072-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-2072-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f6b177986ab89676fcca2b1fdedad580896b8c3
# Push it to GitHub
git push --set-upstream origin backport/backport-2072-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2072-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f6b177986ab89676fcca2b1fdedad580896b8c3
# Push it to GitHub
git push --set-upstream origin backport/backport-2072-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-2072-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f6b177986ab89676fcca2b1fdedad580896b8c3
# Push it to GitHub
git push --set-upstream origin backport/backport-2072-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17Then, create a pull request where the |
…ed and a flaky test (#2072) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 8f6b177)
…ed and a flaky test (#2072) (#2075) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 8f6b177)
…ed and a flaky test (#2072) (#2075) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 8f6b177) (cherry picked from commit 0eaa5a0)
…ed and a flaky test (#2072) (#2075) (#2077) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 8f6b177) (cherry picked from commit 0eaa5a0) Co-authored-by: Navneet Verma <[email protected]>
…ed and a flaky test (opensearch-project#2072) Signed-off-by: Navneet Verma <[email protected]>
Description
Fixing KNNMethodContext resolution when documents are ingested and a flaky test
Bug Fixes:
testDeletedDocsWithSegmentMerge_whenValid_ThenSucceed. It was added in the PR: Fix the force merge with Quantization failures when a segment has deleted docs in it #2046 to test that merges are happening without any failures. But as this test was doing search at the end it is not necessary that search will always give consistent results as the documents are deleted. Hence the correct test for this is ensuring the index is green after the merge. The flakiness was observed here: Fix the force merge with Quantization failures when a segment has deleted docs in it #2046Issue
#1949
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.