Skip to content

Fix expected string for get model response tests#2062

Merged
ryanbogan merged 1 commit intoopensearch-project:mainfrom
ryanbogan:fix_model_tests
Sep 6, 2024
Merged

Fix expected string for get model response tests#2062
ryanbogan merged 1 commit intoopensearch-project:mainfrom
ryanbogan:fix_model_tests

Conversation

@ryanbogan
Copy link
Member

Description

Fixes expected string for model tests to always read the current version.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ryanbogan ryanbogan merged commit 7bf52ac into opensearch-project:main Sep 6, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-2062-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7bf52ac59f469e7e4a713513070a54d59e00e966
# Push it to GitHub
git push --set-upstream origin backport/backport-2062-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-2062-to-2.17.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2062-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7bf52ac59f469e7e4a713513070a54d59e00e966
# Push it to GitHub
git push --set-upstream origin backport/backport-2062-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2062-to-2.x.

ryanbogan added a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit 7bf52ac)
ryanbogan added a commit that referenced this pull request Sep 6, 2024
akashsha1 pushed a commit to akashsha1/k-NN that referenced this pull request Sep 16, 2024
jingqimao77-spec pushed a commit to jingqimao77-spec/k-NN that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants