Skip to content

Makes NativeEngines990KnnVectorFormat as default for index version#2020

Merged
navneet1v merged 1 commit intoopensearch-project:mainfrom
shatejas:native-writer-on
Sep 3, 2024
Merged

Makes NativeEngines990KnnVectorFormat as default for index version#2020
navneet1v merged 1 commit intoopensearch-project:mainfrom
shatejas:native-writer-on

Conversation

@shatejas
Copy link
Collaborator

@shatejas shatejas commented Sep 3, 2024

starting 2.17

This removes the feature flag for the same

Check List

  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

starting 2.17

This removes the feature flag for the same

Signed-off-by: Tejas Shah <[email protected]>
@navneet1v navneet1v merged commit 6b197be into opensearch-project:main Sep 3, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2020-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b197be39be4dbe96417d9410b858a33f239ca10
# Push it to GitHub
git push --set-upstream origin backport/backport-2020-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2020-to-2.x.

shatejas added a commit to shatejas/k-NN that referenced this pull request Sep 3, 2024
…pensearch-project#2020)

starting 2.17

This removes the feature flag for the same

Signed-off-by: Tejas Shah <[email protected]>
(cherry picked from commit 6b197be)
heemin32 pushed a commit that referenced this pull request Sep 3, 2024
…2020) (#2021)

starting 2.17

This removes the feature flag for the same

Signed-off-by: Tejas Shah <[email protected]>
(cherry picked from commit 6b197be)
shatejas added a commit to shatejas/k-NN that referenced this pull request Sep 3, 2024
…pensearch-project#2020)

starting 2.17

This removes the feature flag for the same

Signed-off-by: Tejas Shah <[email protected]>
(cherry picked from commit 6b197be)
akashsha1 pushed a commit to akashsha1/k-NN that referenced this pull request Sep 16, 2024
…pensearch-project#2020)

starting 2.17

This removes the feature flag for the same

Signed-off-by: Tejas Shah <[email protected]>
@shatejas shatejas deleted the native-writer-on branch November 27, 2024 16:13
jingqimao77-spec pushed a commit to jingqimao77-spec/k-NN that referenced this pull request Mar 15, 2026
…pensearch-project#2020)

starting 2.17

This removes the feature flag for the same

Signed-off-by: Tejas Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants