[Backport 3.3] fix(forecast): auto-expand replicas for default results index on 3AZ … #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…domains (#1615) When running forecasting on a 3AZ domain with awareness attributes=3, the forecaster failed to initialize with: IllegalArgumentException: Validation Failed: 1: expected total copies needs to be a multiple of total awareness attributes [3]; The default forecast results index was created with: - number_of_shards: 1 - number_of_replicas: 1 This gives 2 total copies, which violates the 3AZ awareness requirement and causes index creation to fail, so all forecasting results errored on 3AZ domains. This change updates IndexManagement.java to: - set auto_expand_replicas to "0-2" for the default forecast results index Single-AZ domains remain replica-free, while 3AZ domains automatically allocate 2 replicas (3 total copies), satisfying the awareness constraint and allowing forecasters to initialize successfully. Test: 1. manual test Signed-off-by: kaituo <[email protected]> (cherry picked from commit 36acc7b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
VijayanB,
amitgalitz,
dbwiddis,
jackiehanyang,
jmazanec15,
jngz-es,
joshpalis,
kaituo,
ohltyler,
owaiskazi19,
saratvemulapalli,
sean-zheng-amazon,
vamshin and
ylwu-amzn
as code owners
kaituo
approved these changes
Dec 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #1625 +/- ##
============================================
+ Coverage 81.44% 81.45% +0.01%
- Complexity 6135 6142 +7
============================================
Files 542 542
Lines 24898 24894 -4
Branches 2540 2540
============================================
Hits 20278 20278
- Misses 3353 3354 +1
+ Partials 1267 1262 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 36acc7b from #1615.