Skip to content

Ternary operator should not be nested #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pstreef merged 51 commits into from
Aug 22, 2023
Merged

Ternary operator should not be nested #93

Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
3fe1ea9
feat: create new recipe Ternary operators should not be nested
ps-twill May 6, 2023
0ac3205
cleanup imports
ps-twill May 6, 2023
f3b83bc
update todo comment to complete solution
ps-twill May 6, 2023
2d31776
add another todo true part
ps-twill May 6, 2023
6ddccf8
Add more tests
ps-twill May 7, 2023
67f4d01
try something different
ps-twill May 7, 2023
e80ae76
reorder tests
ps-twill May 7, 2023
44b6f66
revert to return extra block
ps-twill May 7, 2023
fab13fa
add todo
ps-twill May 7, 2023
5495fd3
helpers and dont reuse old return (maybe ids will conflict?)
pstreef May 7, 2023
b4409cb
add truePart
pstreef May 7, 2023
0741ab1
and remove todo
pstreef May 7, 2023
f4d10b4
add todo
pstreef May 7, 2023
a45963b
override tags
pstreef May 7, 2023
8d817c3
Fix tests
pstreef May 8, 2023
6fa7287
remove todo
pstreef May 8, 2023
00eb8f8
remove todo & rename method
pstreef May 8, 2023
a942e5e
add more tests
pstreef May 8, 2023
dadbc95
add license
pstreef May 8, 2023
bbdc5de
add test with whitespace
pstreef May 9, 2023
d42304c
Merge remote-tracking branch 'origin/main' into feature/recipe-ternar…
pstreef May 18, 2023
e376b96
Handle ternary in lambda
pstreef May 18, 2023
4f29673
cleanup
pstreef May 18, 2023
8bd105f
cleanup
pstreef May 18, 2023
83ddd72
only when nested ternary
pstreef May 18, 2023
226bad0
add @Issue link
pstreef May 18, 2023
d024aa1
recursive approach for multi level ternaries. Add failing test for co…
pstreef May 23, 2023
ad746b5
Merge remote-tracking branch 'origin/main' into feature/recipe-ternar…
pstreef May 27, 2023
97bc24a
getting there!
pstreef May 30, 2023
f1ab378
getting there!
pstreef May 30, 2023
a880914
fix another test
pstreef May 30, 2023
eb65ba1
add Objects.equals handling
pstreef May 30, 2023
8dc7e3e
add binary conditions
pstreef May 30, 2023
a0dea8e
add more tests
pstreef May 30, 2023
81c40a0
remove todo
pstreef May 30, 2023
8fb6fa3
Merge remote-tracking branch 'origin/main' into feature/recipe-ternar…
pstreef May 30, 2023
885a61a
end visiting of subtree at CompilationUnit
pstreef May 30, 2023
c096386
use javaVersion in tests
pstreef May 30, 2023
4ff8cbd
fixes
pstreef May 30, 2023
5d0b21b
add constant handling for binaries
pstreef May 30, 2023
896784f
other side of equals must be constant
pstreef May 30, 2023
905207b
use helper
pstreef May 30, 2023
6c9e11a
Merge remote-tracking branch 'origin/main' into feature/recipe-ternar…
pstreef May 31, 2023
1aeba33
fix build with latest rewrite:main
pstreef May 31, 2023
123f7bb
Merge branch 'openrewrite:main' into feature/recipe-ternary-operator-…
pstreef Aug 21, 2023
f7beb4c
remove default duration
pstreef Aug 22, 2023
8d57951
Ignore Objects.equals when finding switch expression candidates as it…
pstreef Aug 22, 2023
e8a0848
Add more test nesting
pstreef Aug 22, 2023
5b47f8a
Merge branch 'main' into feature/recipe-ternary-operator-should-not-b…
timtebeek Aug 22, 2023
2a0cf6e
Add two DocumentExamples
timtebeek Aug 22, 2023
a2d96ab
add links to issues
pstreef Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading