Updating MoveFieldAnnotationToType to handle moving annotation which are fully defined #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/staticanalysis/java/MoveFieldAnnotationToType.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/java/MoveFieldAnnotationToType.java
Outdated
Show resolved
Hide resolved
…are fully defined The previous behaviour `public void someFunction(@org.openrewrite.internal.lang.Nullable org.openrewrite.internal.MetricsHelper metrics)` --> `public void someFunction([email protected] MetricsHelper metrics)` New behaviour `public void someFunction(@org.openrewrite.internal.lang.Nullable org.openrewrite.internal.MetricsHelper metrics)` --> `public void someFunction(org.openrewrite.internal.@nullable MetricsHelper metrics)`
…otationToType.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…otationToType.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lkerford
force-pushed
the
fixing-moving-annotation-with-fully-defined-names
branch
from
98ed9eb to
3d42009
Compare
timtebeek
reviewed
Oct 23, 2024
src/test/java/org/openrewrite/staticanalysis/java/MoveFieldAnnotationToTypeTest.java
Show resolved
Hide resolved
timtebeek
approved these changes
Oct 23, 2024
lkerford
deleted the
fixing-moving-annotation-with-fully-defined-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behaviour, move the fully qualified name which won't compile
The previous behaviour
public void someFunction(@org.openrewrite.internal.lang.Nullable org.openrewrite.internal.MetricsHelper metrics)-->public void someFunction([email protected] MetricsHelper metrics)New behaviour
public void someFunction(@org.openrewrite.internal.lang.Nullable org.openrewrite.internal.MetricsHelper metrics)-->public void someFunction(org.openrewrite.internal.@Nullable MetricsHelper metrics)related issue