Skip to content

Conversation

@BoykoAlex
Copy link
Contributor

If type casts to types with defined type parameters are used, i.e. List<Object>, List<String> it is difficult to determine if possible at all if instanceof List list or instanceof List<?> list isappropriate. Soem cases where type cast without type params is used and with it is impossible to determine. Therefore, I think it is best not to touch such instanceof <-> type cats patterns.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/staticanalysis/InstanceOfPatternMatch.java
    • lines 299-301

@sambsnyd sambsnyd merged commit 35606d1 into openrewrite:main Oct 1, 2024
@sambsnyd
Copy link
Member

sambsnyd commented Oct 1, 2024

Thanks @BoykoAlex !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants