Skip to content

Conversation

@blipper
Copy link
Contributor

@blipper blipper commented Aug 20, 2024

What's your motivation?

Make less cautious!

@timtebeek timtebeek self-requested a review August 21, 2024 07:59
@timtebeek timtebeek added the enhancement New feature or request label Aug 21, 2024
@timtebeek
Copy link
Member

Thanks for adding this @blipper ! I've pushed a small fix to your test: it was missing the rewriteRun method invocation, so nothing was tested. I've also added two more Java SourceSpecs to check handling of the special cases outlined in #330. With that I think we're good to merge. :)

@timtebeek
Copy link
Member

Remaining test failure caused by

Will pick that up separately; thanks again!

@timtebeek timtebeek merged commit 5aaf59f into openrewrite:main Aug 21, 2024
@timtebeek
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

UseStringReplace is overly cautious around the use of =

2 participants