Do not ReplaceLambdaWithMethodReference for class fields #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As references might change.
Member
Author
|
Saving others a click with these expected failures: org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReferenceTest |
knutwannheden
approved these changes
Feb 9, 2024
Contributor
knutwannheden
left a comment
knutwannheden
left a comment
There was a problem hiding this comment.
Seems reasonable to me. It should be safe if the field has the final modifier (also available via type attribution). Using that we should be able to make this a little bit less restrictive.
Member
Author
|
Thanks! That extra check indeed meant I only had to change one test that only seemed to use fields by chance. |
timtebeek
deleted the
do-not-replaceLambdaWithMethodReference-for-class-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your motivation?
ReplaceLambdaWithMethodReferencechanges() -> field.getValue()tofield::getValue, with runtime NPE if field is only initialized later.Anything in particular you'd like reviewers to focus on?
This is currently too broad and breaking three original test cases, but I'm not quite sure how to narrow it down further. From the perspective of do-no-harm we might disable those test cases though, as the addition here is safer.