Skip to content

No method reference on new class select #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 1 commit into from
Nov 6, 2023
Merged

No method reference on new class select #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/org/openrewrite/staticanalysis/ReplaceLambdaWithMethodReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,9 @@ public J visitLambda(J.Lambda lambda, ExecutionContext executionContext) {
.build()
.apply(getCursor(), l.getCoordinates().replace(), className((J.NewClass) method));
} else if (select != null) {
return newInstanceMethodReference(methodType, select, lambda.getType()).withPrefix(lambda.getPrefix());
if (!(select instanceof J.NewClass)) {
return newInstanceMethodReference(methodType, select, lambda.getType()).withPrefix(lambda.getPrefix());
}
} else {
String templ = "#{}::#{}";
return JavaTemplate.builder(templ)
Expand Down
28 changes: 28 additions & 0 deletions src/test/java/org/openrewrite/staticanalysis/ReplaceLambdaWithMethodReferenceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,4 +1290,32 @@ private Integer foo(String bar) {
)
);
}

@Test
void newInstanceMethodCall() {
rewriteRun(
//language=java
java(
"""
class A {
int seen = 0;
String lower(String s) {
seen++;
return s.toLowerCase();
}
}
"""
),
java(
"""
import java.util.stream.Stream;
class B {
void bar(Stream<String> stream) {
stream.map(s -> new A().lower(s));
}
}
"""
)
);
}
}