RemoveEmptyJavaDocParameters: added tests + fixed bugs #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
approved these changes
Oct 19, 2023
Member
timtebeek
left a comment
timtebeek
left a comment
There was a problem hiding this comment.
Nice! I'd briefly explored this previously, but indeed found the code hard to follow. Glad that's sorted now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
There was a lot of missing scenarios on the tests that were causing bugs (wrong format of last lines, first lines, even index out of bounds on some very rare scenarios).
Added all the missing combinations of [param, return, throws], [regular, singleLine, firstLine], [withSpace, noSpace].
Fixed the bugs not originally covered with the new tests.
What's your motivation?
Fixes https://github.com/moderneinc/support-app/issues/14 and hopefully all other bugs in this recipe.
Anyone you would like to review specifically?
@timtebeek @knutwannheden
Checklist
./gradlew licenseFormat