Don't redeclare EnumSet as Set #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That changes the type of the generic, potentially breaking iterators. Fixes openrewrite#179
timtebeek
reviewed
Oct 2, 2023
src/test/java/org/openrewrite/staticanalysis/UseCollectionInterfacesTest.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Oct 2, 2023
Member
|
Thanks again! Really helpful all these fixes left and right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That changes the type of the generic, potentially breaking iterators.
Fixes #179
What's changed?
Exclude EnumSet from the recipe.
Anything in particular you'd like reviewers to focus on?
I've not commented in the recipe but rather created a unit test to verify that EnumSet doesn't get back into the recipe on accident.
Checklist