Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,28 @@
*/
package org.openrewrite.staticanalysis;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.openrewrite.DocumentExample;
import org.openrewrite.Issue;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;

import static org.openrewrite.java.Assertions.java;

class LambdaBlockToExpressionTest implements RewriteTest {

@Override
public void defaults(RecipeSpec spec) {
spec.recipe(new LambdaBlockToExpression())
.parser(JavaParser.fromJavaVersion().logCompilationWarningsAndErrors(true));
}

@DocumentExample
@SuppressWarnings("CodeBlock2Expr")
@Test
void simplifyLambdaBlockToExpression() {
rewriteRun(
spec -> spec.recipe(new LambdaBlockToExpression()),
//language=java
java(
"""
Expand All @@ -55,7 +61,6 @@ class Test {
@Issue("https://github.com/openrewrite/rewrite-static-analysis/issues/1")
void simplifyLambdaBlockToExpressionWithComments() {
rewriteRun(
spec -> spec.recipe(new LambdaBlockToExpression()),
//language=java
java(
"""
Expand All @@ -78,4 +83,44 @@ class Test {
)
);
}

@Test
@Issue("https://github.com/openrewrite/rewrite-static-analysis/issues/162")
void simplifyLambdaBlockWithAmbiguousMethod() {
//language=java
rewriteRun(
java("""
import java.util.function.Function;
import java.util.function.Consumer;
class A {
void aMethod(Consumer<Integer> consumer){
}

void aMethod(Function<Integer,String> function){
}
}
"""),
java(
"""
class Test {
void doTest() {
A a = new A();
a.aMethod(value -> {
return value.toString();
});
}
}
""",
"""
class Test {
void doTest() {
A a = new A();
a.aMethod(value -> value.toString());
}
}
"""
)
);
}

}