do not remove try block if there are resources #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmccarp
approved these changes
Aug 24, 2023
timtebeek
approved these changes
Aug 24, 2023
kmccarp
reviewed
Aug 24, 2023
src/main/java/org/openrewrite/staticanalysis/EmptyBlockVisitor.java
Outdated
Show resolved
Hide resolved
sambsnyd
approved these changes
Aug 24, 2023
src/main/java/org/openrewrite/staticanalysis/EmptyBlockVisitor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Try with resources can have side effects (closing the streams) even with empty try blocks. So we cannot delete it safely.
Modified the emptyTry test to not have resources (so it's removed because it's empty), and added a new emptyTryWithResources that is actually not removed because it has resources.
Anyone you would like to review specifically?
@kmccarp
Checklist
./gradlew licenseFormat