-
Notifications
You must be signed in to change notification settings - Fork 92
Explicitly sorted streams should be collected to a LinkedHashSet to preserve order #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for implementing this @RossZhang-cpu ! I like how you figured out all the steps to adding a method matcher, and finding both the select and argument to that method to determine when to apply the changes. Very nice first contribution here if I'm not mistaken. I've gone ahead and gave it a quick polish in 802928a with more details in the commit message, mostly to shorten it such that there's less to maintain. Thanks again & hope you'll consider contributing more! :) |
|
Failures unrelated; and only in Kotlin which is actively worked on by @traceyyoshima today. Something to figure out on the main branch. |
|
@timtebeek Thank you very much! I am very excited to see my first pr was merged in a short time. This has been an invaluable opporturnity for me to learn something new and improve through this project. And it couldn't be done without your and @yeikel's kind help and guidence. Your willingness to take the time to help new contributors like me is greatly appreciated. Thank you again and I will definitely contribute more:) |
|
Glad to hear! Anything tagged "good first issue" is typically good to pick up; feel free to tag me in any issue that you're considering such that I can help see if there's any notes for the implementation. I look forward to what you'll do next! |
New Recipe SorteSetStreamCollectToLinkHashSet to address issue #70
What's changed?
This pull request adds a new recipe called SorteSetStreamCollectToLinkHashSet that converts streams of sorted sets to LinkHashSet for collection instead of HashSet.
What's your motivation?
The motivation is to address issue #70
Anyone you would like to review specifically?
@timtebeek @yeikel, thank you in advance.
Checklist
./gradlew licenseFormat