org.openrewrite.staticanalysis.RemoveUnusedPrivateFields does not recognize @Data Lombok annotation

[gwydionmv]

Hello!

Similar to this other open issue here, the recipe RemoveUnusedPrivateFields is deleting private fields even though the class is annotated as @DaTa.

I am using

• OpenRewrite Maven plugin v5.19.0
• rewrite-static-analysis v1.2.0

I can help working on fixing this issue if you find it interesting too :D

[timtebeek]

Hi @gwydionmv ! Thanks for pointing that out and offering to help.

I imagine the fix would be similar to what we do for explicit initialization:

rewrite-static-analysis/src/main/java/org/openrewrite/staticanalysis/ExplicitInitializationVisitor.java

Lines 59 to 62 in a5dc2f7

	Iterator<Cursor> clz = getCursor().getPathAsCursors(c -> c.getValue() instanceof J.ClassDeclaration);
	if (clz.hasNext() && service(AnnotationService.class).matches(clz.next(), LOMBOK_VALUE)) {
	return v;
	}

Which we then test here

rewrite-static-analysis/src/test/java/org/openrewrite/staticanalysis/ExplicitInitializationTest.java

Lines 66 to 81 in 6a38549

	@Test
	void ignoreLombokValueField() {
	rewriteRun(
	spec -> spec.parser(JavaParser.fromJavaVersion().classpath("lombok")),
	//language=java
	java(
	"""
	import lombok.Value;
	@Value
	class Test {
	boolean b = false;
	}
	"""
	)
	);
	}

[timtebeek]

We would likely need similar handling in RemoveUnusedPrivateFields

rewrite-static-analysis/src/main/java/org/openrewrite/staticanalysis/RemoveUnusedPrivateFields.java

Lines 67 to 68 in e57dac0

	public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, ExecutionContext ctx) {
	J.ClassDeclaration cd = super.visitClassDeclaration(classDecl, ctx);

And best to have a matching test as well in

rewrite-static-analysis/src/test/java/org/openrewrite/staticanalysis/RemoveUnusedPrivateFieldsTest.java

Lines 26 to 30 in 23ee04c

	class RemoveUnusedPrivateFieldsTest implements RewriteTest {
	@Override
	public void defaults(RecipeSpec spec) {
	spec.recipe(new RemoveUnusedPrivateFields());
	}

[timtebeek]

Would be much appreciated if you could provide a fix for that, which I'll gladly review shortly. We can then do the same for #8 too.

[gwydionmv]

I just created the PR @timtebeek 😄 #244

[timtebeek]

Many thanks! Fixed in

• #242 Fix remove unused private fields #244