Add comprehensive conflict policy #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
approved these changes
Nov 19, 2025
Member
|
Thank you, can you increase the package.json version so we can release a new version? |
| for (const publication of (profile.content?.publications || [])) { | ||
| let year = -1; | ||
| if (publication.content?.year) { | ||
| const convertedYear = parseInt(publication.content.year, 10); |
Member
Author
There was a problem hiding this comment.
How can you tell it's v1 vs v2?
| if (nYears) { | ||
| const cutoffDate = new Date(); | ||
| cutoffDate.setFullYear(cutoffDate.getFullYear() - nYears); | ||
| cutOffYear = cutoffDate.getFullYear(); |
Contributor
There was a problem hiding this comment.
the year is set in cutoffDate but only the year is used
so i think this logic is equivalent to
current year - nYears
Contributor
|
i think getComprehensiveProfileInfo method itself requires unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the comprehensive conflict policy to the JS client. The only difference between this and the NeurIPS policy is that this takes internships into account for conflict detection.