Open
Conversation
Member
Author
|
I'm unsure how to add a PyTest for this since we don't have tests to assert the structure of the compiled pipeline - but I could look into adding them |
melisabok
reviewed
Jan 16, 2026
|
|
||
| # Create a temporary config file | ||
| config_content = """ | ||
| PIPELINE_TIMEOUT_SMALL = '86400s' |
Member
There was a problem hiding this comment.
can you set a timeout of 1 second, run a job and expect to receive an error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a timeout to the score computation step of the Vertex AI Pipeline. The timeout cannot be set at runtime (e.g passed as a parameter per request at
create_job) because the timeout is a compiled property of that pipeline step.Tested by deploying to the dev site and checking that jobs fail when the config is set to 1 second (Branch:
feature/vertex-timeout-1s)