Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This refactoring consolidates role definitions and streamlines authorization logic by moving
Role,UserRole, andGroupRolefrom a separateroles.pymodule intorole.py,user.py, andgroup.py, respectively.Technical Details:
Roleenum, previously defined insrc/datastores/sql/models/roles.py, is now located insrc/datastores/sql/models/role.py. This centralizes the role definitions and removes the need for a dedicatedroles.pyfile. This improves code organization and makes it easier to manage role-related logic.UserRoleandGroupRolemodels, originally defined inroles.py, have been moved intouser.pyandgroup.py, respectively. This change more closely couples roles with the entities they pertain to (users and groups), promoting better code cohesion and simplifying related database operations. This reduces unnecessary imports and clarifies the relationships between users, groups, and their respective roles.Role,UserRole, andGroupRoledefinitions. The relationships between these models and other models (e.g.,File,Folder) have been preserved to maintain database integrity. Thegroup_user_association_tableis now directly referenced inuser.py, further streamlining the code.src/datastores/sql/models/roles.pyfile has been deleted as its contents have been migrated to other modules. This removes redundancy and simplifies the project structure.