Open
Conversation
- Convert to ES6 syntax (const/let, arrow functions) - Add UMD wrapper for AMD/CommonJS/browser support - Fix zoom bug: disable CSS transitions during zoom to prevent marker floating to new position - Remove legacy _chunk() fallback for non-CSS3 browsers - Rename 'clickable' option to 'interactive' (Leaflet 1.x naming) - Add proper cleanup in onRemove()
Adds AnimatedMarker.d.ts with: - AnimatedMarkerOptions interface extending MarkerOptions - AnimatedMarker class with start(), stop(), setLine() methods - Factory function animatedMarker() - JSDoc comments for all public API
Comprehensive tests covering: - Constructor and initialization - Default and custom options - setLine() functionality - autoStart behavior - start() and stop() methods - onEnd callback execution - Animation progression through waypoints - Zoom bug fix (transition disable/enable) - Event listener cleanup on remove - Factory function
- Bump version to 1.1.0 - Add types field for TypeScript support - Add files field to specify published files - Add test scripts (vitest run, vitest watch) - Add keywords for better npm discoverability - Add peerDependencies for leaflet ^1.0.0 - Add devDependencies: vitest, jsdom, leaflet - Update homepage URL to use https
Bower has been deprecated since 2017. npm is the standard package manager for JavaScript packages.
index.html: - Remove IE conditional comments - Update Leaflet CDN to 1.9.4 - Remove jQuery dependency - Clean up HTML structure demo.js: - Convert to ES6 syntax (const, arrow functions, forEach) - Replace jQuery with vanilla JS - Switch to CARTO basemap tiles (MapBox tiles no longer free) - Use CSS transitions instead of jQuery fadeOut
- Add npm and license badges - Add requirements section - Add installation instructions (npm, CDN) - Add ES modules and TypeScript usage examples - Add options table with descriptions - Add methods documentation - Add development section with test commands - Add changelog documenting all 1.1.0 changes - Modernize all code examples to ES6 syntax
The test was checking exact _i values at each timer tick, but the actual timing depends on distance calculations. Simplified to verify the animation starts, progresses, and completes with onEnd callback.
The map was floating on top of the start button and logo ribbon. Increased z-index to 1000 for both #start and #branding to ensure they appear above Leaflet's map controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.d.tsfile with JSDoc commentsTest plan
npm install && npm test- all 16 tests should passnpx serve .and openhttp://localhost:3000/example/