Skip to content

Conversation

@snowvirus
Copy link

@snowvirus snowvirus commented Oct 18, 2025

TRUNK-5731: Ensure the Lucene index is upgraded

Description of what I changed

Issue I worked on

see issue i worked on

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@snowvirus
Copy link
Author

@ibacher
take a review

@ManojLL
Copy link
Contributor

ManojLL commented Oct 23, 2025

@snowvirus have you had a chance to go through this : https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips

@snowvirus
Copy link
Author

@snowvirus have you had a chance to go through this : https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips
yes, I have gone through and I think I have corrected the remaining item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants