AC-734 Fixed the orientation in the Dashboard layout#814
AC-734 Fixed the orientation in the Dashboard layout#814rishabh-997 merged 1 commit intoopenmrs:masterfrom
Conversation
sachin-0102
changed the title
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
==========================================
- Coverage 13.64% 13.63% -0.01%
==========================================
Files 237 237
Lines 9552 9553 +1
Branches 917 918 +1
==========================================
Hits 1303 1303
- Misses 8143 8144 +1
Partials 106 106
Continue to review full report at Codecov.
|
sachin-0102
force-pushed
the
fixLayout
branch
from
e12c9ba to
33769bd
Compare
|
@rishabh-997 sir please have a look, I've made the required chnages |
.idea/render.experimental.xml
Outdated
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Why is this file required?
There was a problem hiding this comment.
This file was auto created on changing the table layout to constraint layout
|
|
||
| <androidx.cardview.widget.CardView xmlns:card_view="http://schemas.android.com/apk/res-auto" | ||
| android:id="@+id/cardView" | ||
| android:id="@+id/cardView1" |
There was a problem hiding this comment.
Explain this change
When I changed the table layout to constraint layout, the ids changed to cardView5 , cardView6 etc... So I renumbered them from 1 to 5
There was a problem hiding this comment.
Is this the correct file?
There was a problem hiding this comment.
The ids were changed in the entire app when I changed the table layout
So I though it would be best to convert it back in the entire app
There was a problem hiding this comment.
I'll change it back
| android:layout_marginLeft="8dp" | ||
| android:layout_marginTop="16dp" | ||
| android:layout_marginRight="12dp" | ||
| android:stretchColumns="1"> |
There was a problem hiding this comment.
What is the use of android:stretchColumns here?
There was a problem hiding this comment.
Explain or revert the above queries
On it
| android:contentDescription="@string/dashboard_registry_icon_label" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/FormsLabel" |
There was a problem hiding this comment.
use camelCase to name view ids.
rishabh-997
left a comment
rishabh-997
left a comment
There was a problem hiding this comment.
Explain or revert the above queries
sachin-0102
force-pushed
the
fixLayout
branch
2 times, most recently
from
3cf84a6 to
8ff072d
Compare
|
|
||
|
|
||
| <androidx.cardview.widget.CardView | ||
| android:id="@+id/cardView" |
There was a problem hiding this comment.
@LuGO0, do you think we should name it to something more meaningful?
There was a problem hiding this comment.
@rishabh-997 we can make it more descriptive .
There was a problem hiding this comment.
Rename all 5 card views to functionCardView. Ex findPatientCardView
There was a problem hiding this comment.
Okay sir I'll do it.
|
@sachin-0102 The issue is still not claimed, |
Yes sir. The last comment on the issue said that anyone could take that up so I made a PR, I'll keep that in mind from next time. |
sachin-0102
force-pushed
the
fixLayout
branch
from
8ff072d to
19e66d9
Compare
|
|
||
| <androidx.cardview.widget.CardView xmlns:card_view="http://schemas.android.com/apk/res-auto" | ||
| android:id="@+id/cardView" | ||
| android:id="@+id/findPatientsCardView" |
There was a problem hiding this comment.
make it patientCardView
There was a problem hiding this comment.
Read the PR tips carefully... You still lack two changes before I merge it... Ill leave that to you to explore :)
https://wiki.openmrs.org/display/docs/Pull+Request+Tips
sachin-0102
changed the title
sachin-0102
force-pushed
the
fixLayout
branch
from
19e66d9 to
42ea1fe
Compare
sachin-0102
force-pushed
the
fixLayout
branch
from
42ea1fe to
ecc07da
Compare
rishabh-997
left a comment
rishabh-997
left a comment
There was a problem hiding this comment.
Nice Work. Follow the instructions carefully next time. Keep contributing, thanks :)
rishabh-997
changed the title
|
For sure @rishabh-997 sir. Thank you for your guidance. |
sir, the claim issue button on jira issue tracker is not there how should i claim on an issue ? |
5 participants
Description of what I changed
Fixed the orientation of dashboard layout and alignment of text
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-734
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)