AC-832 Migrating type converter package to kotlin and fixing minor issue with type converters#811
Conversation
|
@f4ww4z @rishabh-997 please check up the changes once before I convert them into kotlin!! |
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
=======================================
Coverage 13.64% 13.64%
=======================================
Files 237 236 -1
Lines 9552 9552
Branches 917 918 +1
=======================================
Hits 1303 1303
Misses 8143 8143
Partials 106 106
Continue to review full report at Codecov.
|
rishabh-997
left a comment
There was a problem hiding this comment.
Changes are fine, you can migrate them to kotlin 👍
|
@rishabh-997 i will convert them into kotlin soon just caught up in some work, will make the PR ready for review then 👍 |
rishabh-997
left a comment
There was a problem hiding this comment.
Nice work @LuGO0, can you try to fix the Travis failure...
|
@rishabh-997 I think its not a travis failure but actually travis failed to start test can you restart the travis test for this commit !! |
6fd0451 to
463c715
Compare
|
@rishabh-997 I rebased its fine now :) |
|
@rishabh I encountered No NPEs while normal usage. |
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-832
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)