Skip to content

AC-835 Migrated Listener package to kotlin#802

Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom
rishabh-997:AC-835-listenerKotlin
Aug 15, 2020
Merged

AC-835 Migrated Listener package to kotlin#802
f4ww4z merged 1 commit intoopenmrs:masterfrom
rishabh-997:AC-835-listenerKotlin

Conversation

@rishabh-997
Copy link
Collaborator

Description of what I changed

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-835

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997
Copy link
Collaborator Author

Haven't migrated CustomCallBack as it is migrated by @LuGO0 in #801

@rishabh-997 rishabh-997 requested a review from f4ww4z August 13, 2020 19:05
@codecov-commenter
Copy link

Codecov Report

Merging #802 into master will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   13.43%   13.46%   +0.03%     
==========================================
  Files         238      238              
  Lines        9698     9676      -22     
  Branches      931      929       -2     
==========================================
  Hits         1303     1303              
+ Misses       8289     8267      -22     
  Partials      106      106              
Impacted Files Coverage Δ
...vities/addeditpatient/AddEditPatientPresenter.java 39.79% <0.00%> (-0.64%) ⬇️
...trofitcallbacks/PatientDeferredResponseCallback.kt 0.00% <0.00%> (ø)
.../mobile/listeners/watcher/LoginValidatorWatcher.kt 0.00% <0.00%> (ø)
...teners/watcher/PatientBirthdateValidatorWatcher.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891cc2b...358cbc9. Read the comment docs.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f4ww4z f4ww4z merged commit 39c8c3e into openmrs:master Aug 15, 2020
@rishabh-997 rishabh-997 deleted the AC-835-listenerKotlin branch August 19, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants