Skip to content

AC-811 Allergy can be updated as per server settings#798

Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom
rishabh-997:AC-811-updateAllergy
Aug 11, 2020
Merged

AC-811 Allergy can be updated as per server settings#798
f4ww4z merged 1 commit intoopenmrs:masterfrom
rishabh-997:AC-811-updateAllergy

Conversation

@rishabh-997
Copy link
Collaborator

Description of what I changed

  1. Since allergen is fixed once created, so haven't given option to change it
  2. Added allergenType field in AllergyEntity
  3. Created appropriate rest calls

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-811

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

AC-811 Allergy can be updated

ggsi

AC-811 Allergy can be updated based on server settings
@rishabh-997 rishabh-997 requested a review from f4ww4z August 9, 2020 20:57
@rishabh-997
Copy link
Collaborator Author

Since I have updated the allergyEntity, so you will need to clear app data to test this @f4ww4z sir. Hopefully, this marks the end of the Allergy Module in Android Client.

@codecov-commenter
Copy link

Codecov Report

Merging #798 into master will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
- Coverage   13.52%   13.43%   -0.10%     
==========================================
  Files         238      238              
  Lines        9632     9698      +66     
  Branches      924      931       +7     
==========================================
  Hits         1303     1303              
- Misses       8223     8289      +66     
  Partials      106      106              
Impacted Files Coverage Δ
...ivities/addeditallergy/AddEditAllergyActivity.java 0.00% <0.00%> (ø)
...ivities/addeditallergy/AddEditAllergyFragment.java 0.00% <0.00%> (ø)
...vities/addeditallergy/AddEditAllergyPresenter.java 0.00% <0.00%> (ø)
...ies/patientdashboard/PatientDashboardActivity.java 0.00% <0.00%> (ø)
...tientdashboard/allergy/PatientAllergyFragment.java 3.38% <0.00%> (-0.19%) ⬇️
...enmrs/mobile/api/repository/AllergyRepository.java 21.27% <0.00%> (-4.37%) ⬇️
.../org/openmrs/mobile/databases/AppDatabaseHelper.kt 0.00% <0.00%> (ø)
...openmrs/mobile/databases/entities/AllergyEntity.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9c817...8b4336e. Read the comment docs.

@rishabh-997 rishabh-997 changed the title AC-811 Allergy can be updated as per sevrer settings AC-811 Allergy can be updated as per server settings Aug 10, 2020
@HerbertYiga
Copy link

thanks @rishabh-997 cc @f4ww4z

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f4ww4z f4ww4z merged commit 891cc2b into openmrs:master Aug 11, 2020
dino-saurabh pushed a commit to dino-saurabh/openmrs-contrib-android-client that referenced this pull request Aug 12, 2020
@rishabh-997 rishabh-997 deleted the AC-811-updateAllergy branch August 19, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants