AC-826 Added repository abstraction for matchingPatients package#797
Merged
f4ww4z merged 2 commits intoopenmrs:masterfrom Aug 6, 2020
Merged
AC-826 Added repository abstraction for matchingPatients package#797f4ww4z merged 2 commits intoopenmrs:masterfrom
f4ww4z merged 2 commits intoopenmrs:masterfrom
Conversation
dino-saurabh
commented
Aug 4, 2020
.../src/main/java/org/openmrs/mobile/activities/matchingpatients/MatchingPatientsPresenter.java
Outdated
Show resolved
Hide resolved
dino-saurabh
changed the title
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 13.70% 13.95% +0.25%
==========================================
Files 228 229 +1
Lines 9289 9329 +40
Branches 897 903 +6
==========================================
+ Hits 1273 1302 +29
- Misses 7917 7921 +4
- Partials 99 106 +7
Continue to review full report at Codecov.
|
dino-saurabh
commented
Aug 5, 2020
| @@ -0,0 +1,29 @@ | |||
| /* | |||
| * The contents of this file are subject to the OpenMRS Public License | |||
| * Version 1.0 (the "License"); you may not use this file except in | |||
Collaborator
Author
There was a problem hiding this comment.
@f4ww4z Sir I dint convert this to kotlin because there were some problems in the kotlin java introperability due to default keyword.
Collaborator
Author
|
@f4ww4z @rishabh-997 review again I fixed the tests they were wrong a bit. |
f4ww4z
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-826
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)