AC 804 Added Allergy Tab to fetch allergies from server#780
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom Jul 14, 2020
Merged
AC 804 Added Allergy Tab to fetch allergies from server#780f4ww4z merged 1 commit intoopenmrs:masterfrom
f4ww4z merged 1 commit intoopenmrs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
+ Coverage 11.85% 12.00% +0.15%
==========================================
Files 255 262 +7
Lines 11063 11173 +110
Branches 1130 1138 +8
==========================================
+ Hits 1311 1341 +30
- Misses 9653 9733 +80
Partials 99 99
Continue to review full report at Codecov.
|
Collaborator
Author
Do add the allergies on the server before testing the changes... @LuGO0 @f4ww4z sir
|
rishabh-997
commented
Jul 10, 2020
...c/main/java/org/openmrs/mobile/activities/patientdashboard/visits/PatientVisitsFragment.java
Outdated
Show resolved
Hide resolved
rishabh-997
commented
Jul 10, 2020
...t/src/main/java/org/openmrs/mobile/activities/patientdashboard/PatientDashboardContract.java
Show resolved
Hide resolved
dino-saurabh
requested changes
Jul 11, 2020
...c/main/java/org/openmrs/mobile/activities/patientdashboard/PatientDashboardPagerAdapter.java
Show resolved
Hide resolved
...c/main/java/org/openmrs/mobile/activities/patientdashboard/PatientDashboardPagerAdapter.java
Show resolved
Hide resolved
...rg/openmrs/mobile/activities/patientdashboard/allergy/PatientAllergyRecyclerViewAdapter.java
Show resolved
Hide resolved
openmrs-client/src/main/java/org/openmrs/mobile/models/AllergyReaction.kt
Show resolved
Hide resolved
created layouts for allergies added models and api path resolving conflicts changed modela classes to kotlin added repository and tests AC-804 Updated string values and variable names added tab count in application constatnt removed star imports AC-804 Added allergy module base in the project
rishabh-997
force-pushed
the
AC-804-allergy-view
branch
from
d1ff891 to
fd634dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-804
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)