AC-777 Migrated Intro package to kotlin#756
Merged
f4ww4z merged 2 commits intoopenmrs:masterfrom Jun 12, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
==========================================
+ Coverage 11.71% 11.74% +0.03%
==========================================
Files 249 249
Lines 10784 10753 -31
Branches 1032 1033 +1
==========================================
Hits 1263 1263
+ Misses 9438 9407 -31
Partials 83 83
Continue to review full report at Codecov.
|
VibhorChinda
approved these changes
Jun 10, 2020
f4ww4z
requested changes
Jun 11, 2020
Collaborator
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
@rishabh-997 Just need you to make small changes.
openmrs-client/src/main/java/org/openmrs/mobile/activities/introduction/SplashActivity.kt
Outdated
Show resolved
Hide resolved
openmrs-client/src/main/java/org/openmrs/mobile/activities/introduction/SplashActivity.kt
Outdated
Show resolved
Hide resolved
dino-saurabh
requested changes
Jun 11, 2020
| val intent = Intent(this@SplashActivity, IntroActivity::class.java) | ||
| startActivity(intent) | ||
| finish() | ||
| } |
Collaborator
There was a problem hiding this comment.
@rishabh-997 can we initialize the mRunnable at the declaration itself rather than using null to initialize it?
| private val mHandler = Handler() | ||
| private var mRunnable: Runnable? = null | ||
| private lateinit var binding: ActivitySplashBinding | ||
|
|
Collaborator
|
@rishabh-997 it generates a type mismatch warning can you look it up? |
Collaborator
Author
|
sure, will see if it comes up in my case and resolve it in any one of the kotlij related PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-777
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)