Skip to content

AC-771 fixed the ill formed provider fields#751

Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom
dino-saurabh:AC-771
Jun 1, 2020
Merged

AC-771 fixed the ill formed provider fields#751
f4ww4z merged 1 commit intoopenmrs:masterfrom
dino-saurabh:AC-771

Conversation

@dino-saurabh
Copy link
Collaborator

Description of what I changed

Corrected the ill formed provider that was being communicated to the servers earlier resulting in internal server error code ie 500 being returned.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-771

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

corrected the ill formed provider that was being communicated to the servers earlier resulting in internal server error code ie 500 being returned.
@dino-saurabh
Copy link
Collaborator Author

@f4ww4z Sir please review.

@codecov-commenter
Copy link

Codecov Report

Merging #751 into master will increase coverage by 0.03%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   11.83%   11.86%   +0.03%     
==========================================
  Files         237      237              
  Lines       10576    10582       +6     
  Branches     1018     1018              
==========================================
+ Hits         1252     1256       +4     
- Misses       9242     9244       +2     
  Partials       82       82              
Impacted Files Coverage Δ
...agerdashboard/addprovider/AddProviderFragment.java 0.00% <0.00%> (ø)
...penmrs/mobile/api/retrofit/ProviderRepository.java 27.27% <0.00%> (-0.86%) ⬇️
...gerdashboard/addprovider/AddProviderPresenter.java 97.05% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f224277...4eb86cf. Read the comment docs.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @LuGO0

@f4ww4z f4ww4z merged commit d9c3f5c into openmrs:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants