Skip to content

AC-769 Added chucker support for API Calls#750

Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom
dino-saurabh:AC-769
May 30, 2020
Merged

AC-769 Added chucker support for API Calls#750
f4ww4z merged 1 commit intoopenmrs:masterfrom
dino-saurabh:AC-769

Conversation

@dino-saurabh
Copy link
Collaborator

@dino-saurabh dino-saurabh commented May 28, 2020

Description of what I changed

  1. Added chucker support, all the functionality works as expected,
  2. I have added that guava dependency because it resolves duplicate classes problem which I faced while making changes to the dependencies in gradle

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-769

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@dino-saurabh
Copy link
Collaborator Author

dino-saurabh commented May 28, 2020

@f4ww4z Sir please review!!

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #750 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   11.83%   11.84%           
=======================================
  Files         237      237           
  Lines       10576    10571    -5     
  Branches     1018     1018           
=======================================
  Hits         1252     1252           
+ Misses       9242     9237    -5     
  Partials       82       82           
Impacted Files Coverage Δ
...ava/org/openmrs/mobile/api/RestServiceBuilder.java 0.00% <0.00%> (ø)
...n/java/org/openmrs/mobile/application/OpenMRS.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f224277...f2429a3. Read the comment docs.

@dino-saurabh dino-saurabh changed the title AC-769 Added chucker support for API AC-769 Added chucker support for API Calls May 28, 2020
Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @LuGO0

@f4ww4z f4ww4z merged commit 9c8e3ca into openmrs:master May 30, 2020
@dino-saurabh dino-saurabh deleted the AC-769 branch May 30, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants