AC-726 : Rectified app crash on lower api devices#749
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom May 25, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
=======================================
Coverage 11.75% 11.75%
=======================================
Files 238 238
Lines 10655 10655
Branches 1028 1028
=======================================
Hits 1252 1252
Misses 9321 9321
Partials 82 82
Continue to review full report at Codecov.
|
dino-saurabh
requested changes
May 23, 2020
Collaborator
dino-saurabh
left a comment
dino-saurabh
left a comment
There was a problem hiding this comment.
@VibhorChinda I think you forgot to add JIRA token number in the commit messages !!
I also forget this often XD .
f4ww4z
approved these changes
May 25, 2020
Collaborator
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
@VibhorChinda Good work, tested and working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
I have extended the base application class from MultiDexApplication class.
I referred following thread https://stackoverflow.com/questions/52696574/didnt-find-class-androidx-core-content-fileprovider
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-726
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)