AC-763 Updated UI for splash screen#744
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 11.80% 11.80% -0.01%
==========================================
Files 238 238
Lines 10647 10650 +3
Branches 1028 1028
==========================================
Hits 1257 1257
- Misses 9308 9311 +3
Partials 82 82
Continue to review full report at Codecov.
|
|
@rishabh-997 thanks for this,you can also add a ticket ID on your commit message |
| binding.organizationName.setTypeface(typeface); | ||
| binding.organizationName.setText(R.string.organization_name); | ||
|
|
||
| binding.clientName.setTypeface(typeface); |
There was a problem hiding this comment.
@rishabh-997 why not assigning the text and fonts directly in the xml file, it will reduce the code here.
There was a problem hiding this comment.
This font is Monserrat which is not available in default font family so had to add the .tff file to use it...
There was a problem hiding this comment.
@rishabh-997 Move line 46 to FontsUtil and just retrieve the Typeface here.
There was a problem hiding this comment.
But we discussed on removing the entire FontUtils.java file ???
There was a problem hiding this comment.
But we discussed on removing the entire FontUtils.java file ???
Ok this is fine for now, but if we want to add more special fonts we might have to recreate FontUtils.
openmrs-client/src/main/java/org/openmrs/mobile/activities/introduction/SplashActivity.java
Show resolved
Hide resolved
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
@rishabh-997 All good except 1 thing.
| binding.organizationName.setTypeface(typeface); | ||
| binding.organizationName.setText(R.string.organization_name); | ||
|
|
||
| binding.clientName.setTypeface(typeface); |
There was a problem hiding this comment.
@rishabh-997 Move line 46 to FontsUtil and just retrieve the Typeface here.
rishabh-997
force-pushed
the
AC-763-splashUI
branch
from
5a47daa to
d1dad5c
Compare
|
@rishabh-997 LGTM except the merge conflict. |
rishabh-997
force-pushed
the
AC-763-splashUI
branch
from
d1dad5c to
c86070a
Compare
| binding.organizationName.setTypeface(typeface); | ||
| binding.organizationName.setText(R.string.organization_name); | ||
|
|
||
| binding.clientName.setTypeface(typeface); |
There was a problem hiding this comment.
But we discussed on removing the entire FontUtils.java file ???
Ok this is fine for now, but if we want to add more special fonts we might have to recreate FontUtils.
5 participants
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-763
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)