AC-729 App Intro Slides are shown on second app run#742
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom May 18, 2020
Merged
AC-729 App Intro Slides are shown on second app run#742f4ww4z merged 1 commit intoopenmrs:masterfrom
f4ww4z merged 1 commit intoopenmrs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
=======================================
Coverage 11.76% 11.76%
=======================================
Files 238 238
Lines 10646 10646
Branches 1027 1027
=======================================
Hits 1252 1252
Misses 9312 9312
Partials 82 82
Continue to review full report at Codecov.
|
dino-saurabh
approved these changes
May 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Just prevented
ACBaseActivityto check if the user is logged in or not inSplashActivityas it caused to triggerLogin PageandAppIntropage was skippedIssue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-729
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)