AC-745 fixed the transition error upon language change#741
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom May 18, 2020
Merged
AC-745 fixed the transition error upon language change#741f4ww4z merged 1 commit intoopenmrs:masterfrom
f4ww4z merged 1 commit intoopenmrs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
- Coverage 11.78% 11.77% -0.01%
==========================================
Files 238 238
Lines 10612 10621 +9
Branches 1022 1023 +1
==========================================
Hits 1251 1251
- Misses 9280 9289 +9
Partials 81 81
Continue to review full report at Codecov.
|
Collaborator
Author
|
@f4ww4z please review !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
after the settings activity returns I recreate the dashboard activity
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-745
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.