AC-757 Fixed EncounterRoomDAO tests#740
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom May 15, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
- Coverage 11.82% 11.78% -0.04%
==========================================
Files 237 238 +1
Lines 10583 10614 +31
Branches 1019 1021 +2
==========================================
Hits 1251 1251
- Misses 9251 9282 +31
Partials 81 81
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
The test for
getAllEncountersByTypewas completely wrong and had to do significant changes to pass this test.Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-754
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)