AC-740 fixed NPE at syncedPatient activity#734
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom May 14, 2020
Merged
Conversation
sanjulamadurapperuma
suggested changes
May 11, 2020
Contributor
sanjulamadurapperuma
left a comment
sanjulamadurapperuma
left a comment
There was a problem hiding this comment.
Requested a change
Collaborator
Author
|
@f4ww4z please review!! |
f4ww4z
requested changes
May 12, 2020
Collaborator
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
@LuGO0 Thanks, just small changes and confirmation needed here.
...lient/src/main/java/org/openmrs/mobile/activities/syncedpatients/SyncedPatientsActivity.java
Show resolved
Hide resolved
...lient/src/main/java/org/openmrs/mobile/activities/syncedpatients/SyncedPatientsActivity.java
Show resolved
Hide resolved
searchView takes up null value in dark mode of operation in absence of ActionBar,thus onCreateOptionsMenu never gets called
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 11.83% 11.78% -0.06%
==========================================
Files 237 238 +1
Lines 10569 10615 +46
Branches 1017 1022 +5
==========================================
Hits 1251 1251
- Misses 9237 9283 +46
Partials 81 81
Continue to review full report at Codecov.
|
Collaborator
|
@LuGO0 Add the ticket id to the commit message next time. |
Collaborator
Author
|
Okay @f4ww4z Ill do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
SearchView takes up null value in dark mode of operation in absence of ActionBar,thus onCreateOptionsMenu never gets called so NPE was thrown.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-740
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.