AC-746 NPE removed at Visit Dashboard#721
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom Apr 22, 2020
Merged
Conversation
dino-saurabh
requested changes
Apr 12, 2020
| "INSERT OR REPLACE INTO room_master_table (id,identity_hash) VALUES(42, \"f2ba83e78fa9d0190a4a24b5be11b2de\")" | ||
| "INSERT OR REPLACE INTO room_master_table (id,identity_hash) VALUES(42, \"41a50b7fab10cb07ddedc8846a9b55f5\")" | ||
| ] | ||
| } |
Collaborator
There was a problem hiding this comment.
@rishabh-997 this file pops up with its modified version always when we build but I think you should keep this file out of this pull request as it is not directly related to this Issue !!
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
=======================================
Coverage 11.90% 11.90%
=======================================
Files 236 236
Lines 10502 10502
Branches 1006 1006
=======================================
Hits 1250 1250
Misses 9171 9171
Partials 81 81
Continue to review full report at Codecov.
|
removed changes in 1.json NPE removed at visit dashboard
dino-saurabh
approved these changes
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
The error was because of a non-null variable in resource file which was being assigned null from the server, so changed it to accumulate null value.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-746
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)