AC-739 Added showcase view to manage providers#720
Merged
f4ww4z merged 2 commits intoopenmrs:masterfrom Apr 18, 2020
Merged
Conversation
f4ww4z
requested changes
Apr 12, 2020
Collaborator
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
@rishabh-997 1 change and you're good to go.
| .build().forceTextPosition(ShowcaseView.ABOVE_SHOWCASE); | ||
| } | ||
|
|
||
| private void showOverlayTutorialFive() { |
Collaborator
There was a problem hiding this comment.
@rishabh-997 Can you refactor these showOverlay... methods by creating 1 helper method that has viewTarget, contentTitle and contentText as parameters? Then there's less code duplicated.
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
+ Coverage 11.90% 11.93% +0.03%
==========================================
Files 236 236
Lines 10502 10475 -27
Branches 1006 1008 +2
==========================================
Hits 1250 1250
+ Misses 9171 9144 -27
Partials 81 81
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-739
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)