AC-732 : offline update bug fixed#718
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom Apr 18, 2020
Merged
Conversation
Collaborator
Author
|
@f4ww4z please review the changes . |
openmrs-client/src/main/java/org/openmrs/mobile/api/workers/UpdateWorker.java
Outdated
Show resolved
Hide resolved
tbagz104
reviewed
Mar 31, 2020
openmrs-client/src/main/java/org/openmrs/mobile/api/workers/UpdateWorker.java
Outdated
Show resolved
Hide resolved
tbagz104
reviewed
Mar 31, 2020
openmrs-client/src/main/java/org/openmrs/mobile/api/repository/PatientRepository.java
Show resolved
Hide resolved
dino-saurabh
force-pushed
the
offline_update_bug
branch
from
63402a3 to
1dc3483
Compare
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
==========================================
- Coverage 11.90% 11.81% -0.09%
==========================================
Files 236 237 +1
Lines 10502 10589 +87
Branches 1006 1015 +9
==========================================
+ Hits 1250 1251 +1
- Misses 9171 9257 +86
Partials 81 81
Continue to review full report at Codecov.
|
f4ww4z
requested changes
Apr 10, 2020
Collaborator
f4ww4z
left a comment
f4ww4z
left a comment
There was a problem hiding this comment.
@LuGO0 Please fix formatting errors, and see my other comments.
...lient/src/main/java/org/openmrs/mobile/activities/addeditpatient/AddEditPatientActivity.java
Outdated
Show resolved
Hide resolved
openmrs-client/src/main/java/org/openmrs/mobile/api/repository/PatientRepository.java
Outdated
Show resolved
Hide resolved
openmrs-client/src/main/java/org/openmrs/mobile/api/workers/UpdateWorker.java
Outdated
Show resolved
Hide resolved
openmrs-client/src/main/java/org/openmrs/mobile/api/workers/UpdateWorker.java
Outdated
Show resolved
Hide resolved
dino-saurabh
force-pushed
the
offline_update_bug
branch
from
85c5452 to
a92beb1
Compare
Provided a WorkManager Implementation for handling deferred updates to server after modification in the details of a patient.
dino-saurabh
force-pushed
the
offline_update_bug
branch
from
a92beb1 to
3e80289
Compare
Collaborator
Author
|
@f4ww4z I have fixed all the formatting errors and made the requested changes please review . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Provided a WorkManager Implementation for handling deferred updates to server after modification in the details of a patient.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-732
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.