AC-714 - AlertDialog not canceled on activity destroyed#713
Merged
f4ww4z merged 1 commit intoopenmrs:masterfrom Mar 26, 2020
AryanGanotra07:master
Merged
AC-714 - AlertDialog not canceled on activity destroyed#713f4ww4z merged 1 commit intoopenmrs:masterfrom AryanGanotra07:master
f4ww4z merged 1 commit intoopenmrs:masterfrom
AryanGanotra07:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
==========================================
- Coverage 12.45% 12.45% -0.01%
==========================================
Files 233 233
Lines 10767 10771 +4
Branches 998 998
==========================================
Hits 1341 1341
- Misses 9345 9349 +4
Partials 81 81
Continue to review full report at Codecov.
|
Collaborator
|
@AryanGanotra07 Can you claim this on JIRA as per https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
Contributor
Author
@f4ww4z sir, I have claimed this issue on Jira. |
VibhorChinda
approved these changes
Mar 24, 2020
Collaborator
|
LGTM |
f4ww4z
approved these changes
Mar 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Alert dialog was not dismissed when activity got destroyed so there was a leak. I have dismissed the alert dialog in the onDestroy method of the activity.
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-714
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)