Skip to content

AC-680 Made TabsVisible and Updated layout of patientDetailFragment#700

Merged
rishabh-997 merged 1 commit intoopenmrs:masterfrom
rishabh-997:tabColour
Feb 11, 2020
Merged

AC-680 Made TabsVisible and Updated layout of patientDetailFragment#700
rishabh-997 merged 1 commit intoopenmrs:masterfrom
rishabh-997:tabColour

Conversation

@rishabh-997
Copy link
Collaborator

Description of what I changed

  1. Changed selectedTabColour in both dashboard activities
  2. Updated layout of patient details fragment to make it interactive

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-680

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997 rishabh-997 requested a review from f4ww4z February 10, 2020 18:08
@rishabh-997
Copy link
Collaborator Author

Screenshots :
UI
TabColor

@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #700 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
+ Coverage    12.5%   12.51%   +<.01%     
==========================================
  Files         233      233              
  Lines       10721    10719       -2     
  Branches      993      993              
==========================================
  Hits         1341     1341              
+ Misses       9299     9297       -2     
  Partials       81       81
Impacted Files Coverage Δ
...tientdashboard/details/PatientDetailsFragment.java 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc04968...376bdeb. Read the comment docs.

@rishabh-997
Copy link
Collaborator Author

I've changed the Ui to make it look more appealing. have a say @f4ww4z @PrathameshMutkure @VibhorChinda

@VibhorChinda
Copy link
Collaborator

@rishabh-997 these changes look good to me. The design is clean and clear.

@rishabh-997 rishabh-997 merged commit c47ef79 into openmrs:master Feb 11, 2020
@rishabh-997 rishabh-997 deleted the tabColour branch February 11, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants